feat(mobile): show the pull request in PR-watch monitor rows - #21412

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This adds a new mobile background-work screen and interaction flow, including PR metadata rendering, child-thread navigation, and opening PRs externally. The feature changes existing background-status behavior and introduces substantial user-facing runtime logic, so it merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 2a73827
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1fc25e6c-03fc-441e-b469-da6e69198562

Commits

Reviewing files that changed from the base of the PR and between 819dbad and acdc2ed.

Files selected for processing: 3

• apps/mobile/src/features/threads/ThreadBackgroundWorkSheet.tsx
• packages/shared/src/orchestrationV2PendingBackgroundWork.test.ts
• packages/shared/src/orchestrationV2PendingBackgroundWork.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Merge Risk: Low · up to acdc2

Some Azure watch rows may open an API response instead of the pull request. The navigation issue is bounded.

Security architecture risk: Low · up to 5da51

The change adds a tap target for already linked pull requests without demonstrating broader access or new privileges. Handling of unexpected link destinations remains partly unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The demonstrated exposure is user-triggered navigation from a displayed thread into the device's URL-handler boundary. Row rendering does not automatically open links. Accepted schemes and the authority exercised by downstream handlers remain outside verified coverage.

Security Findings and Attack Paths

• inferred — No materially new attacker-controlled path was established. Before this PR, linked-pull-request menus already offered an unconditional browser action for the same stored URL, including snapshotless links. The new monitor row adds another trigger for that existing handoff, not a new URL producer or privileged operation.

Trust Boundaries and Controls

• observed — Task matching establishes correspondence with a thread's linked pull request, not destination safety. The unchanged link schema accepts a nonempty URL, and tryOpenExternalUrl forwards it directly to Linking.openURL without application-level scheme or authority validation. Its pull-request target labels error reporting rather than enforcing a navigation policy.

Hardening Proposals

• proposed — As separate hardening of the existing navigation boundary, consider enforcing expected web URL schemes for pull-request destinations, with explicit support for enterprise hosts. This is not a verified vulnerability introduced by this PR.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description explains the problem, implementation, verification, screenshots, limitations, and agent usage. It does not provide the required Scope and approval section or explicit maintainer approv…	Add a Scope and approval section. Link the triaged issue or approval discussion and include the explicit maintainer approval comment, or explain why this focused change qualifies for the exemption. Rename Fix to Change and Evidence to Verif…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the primary mobile change: displaying pull requests in PR-watch monitor rows.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, implementation, verification, screenshots, limitations, and agent usage. It does not provide the required Scope and approval section or explicit maintainer approval, and it uses Fix and Evidence instead of the template headings Change and Verification.

Resolution

Add a Scope and approval section. Link the triaged issue or approval discussion and include the explicit maintainer approval comment, or explain why this focused change qualifies for the exemption. Rename Fix to Change and Evidence to Verification, if required by repository checks.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

Re CodeRabbit review 5638150863 (outside-diff comments), both left as is:

1. repositoryWebUrl for opening the row: per packages/contracts/src/threadPullRequest.ts that field is the repository's browser or clone URL, not the pull request's, so opening it would land on the repo instead of the PR. No other client opens PRs through it. url stays.
2. Checks on closed or merged watch rows: a watch ends when its PR merges or closes, so these rows only describe open PRs in practice; the open-only guard keeps a stale checks badge off a PR that is already done. Not changing it in this PR.

thanks @voida6. the title, state/checks summary, snapshot-free link, and shared watch lookup are preserved. i merged current main (dd5b5401e1) into your branch without rewriting its commits, simplified the repeated checks-label conditions, and made the accessibility hint host-neutral. the final diff is three files, 125 additions and 8 deletions. the background-sheet foundation is already on main; no stacked sheet changes remain in this diff.

verification: vp run check:changed passed through blacksmith-check: format, lint, both knip passes, affected-package typechecks (29 packages), and all 21 existing tests in orchestrationV2PendingBackgroundWork.test.ts. two independent code reviews approved e3cc757341. the existing bot suggestions to use repositoryWebUrl and show checks on closed rows remain unwarranted: the former can be a repository/clone URL, and the latter differs from nearby linked-pr rows.

unverified: native layout, accessibility, tapping and external opening, including before/after screenshots and interaction video. this vm has no connected mobile device or emulator; the app supports ios/android only. i started the default dev server and tried system chrome through playwright, but that web client cannot exercise this native sheet. i stopped the dev processes. the original device captures remain in the description, but i have not treated them as proof for this head.

ci finished on e3cc757341: all 27 reported checks passed or were skipped as configured, with no failures or pending checks; github reports clean mergeability. cafe's check mirror lagged and then returned 503, so i confirmed the final state directly on github. no new bot findings were posted. native verification and human approval are still needed before merging.

@maria-rcks native evidence for this head (e3cc757), Android 16 emulator (Pixel 6 profile), dev server paired to the app, real PR linked and watched through the app's own UI. No debug code.

Before (merge-base dd5b5401e1)	After (e3cc757)

• Tap opens the PR: recording (22 s) from the sheet, tapping the row, ending on feat(mobile): show the pull request in PR-watch monitor rows #21412 open in Chrome (final frame).
• Accessibility: uiautomator dump. The row's label reads "Watching pull request 21412, feat(mobile): show the pull request in PR-watch monitor rows, Open, checks passing".

Not checked: the hint text (uiautomator does not expose accessibilityHint, and TalkBack was not run), the "Unable to open" alert, dark theme, and a physical device. The before capture reverts only this PR's three files to the merge-base on the same native build.

Verified in a real dev environment

verification attempt on head e3cc757341497ccf7825012b7b689b101bf27535, with github/main at 570d4b03ee in a separate worktree. vp i passed in both checkouts. both real dev servers started in the background; main used server/web ports 16733/8693 and the pr used 13773/5733 with isolated .t3 state. both web endpoints returned HTTP 200. this proves startup only, not the changed mobile behavior. no source changes or pushes were made. cafe reports 27 successful ci checks with none failing or pending; that is not runtime verification.

command transcript

Not verified

none of the changed behavior could be exercised on this vm. adb devices -l lists no devices, and t3's device_list returned Agent device access is turned off for this environment. the mobile verification skill requires stopping when device access is unavailable. the changed sheet is native ios/android, so playwright against the web client cannot verify it.

original-bug reproduction on main, native title/state/checks rendering, tapping and external opening, snapshot-free fallback, accessibility, neighboring command/subagent rows, and the real codex gpt-6.1-sol provider-to-mobile path remain unverified. no before/after images or interaction recording were captured. existing contributor evidence was read but was not treated as verification performed in this attempt. a native device host must be enabled to complete this pass.

Verified on Android emulator (API 35) against a real dev server

not verified. this heading records the requested verification scope, not a passing result.

reviewed the diff and discussion at e3cc757341497ccf7825012b7b689b101bf27535. the pr is open, the change supports android, and none of its five pr commits are authored by juliusmarminge or t3dotgg. git.cafe maps this to https://git.cafe/pingdotgg/t3code/pulls/21412. its current check mirror reports 27 successful checks, zero pending and zero failing; those do not prove runtime behavior.

started AVD t3 with the requested headless KVM command. adb detected emulator-5554 and adb shell getprop sys.boot_completed returned 1. the emulator log confirms the android-35 system image and successful boot. however, t3 device_list returned Device support is off. Ask the user to enable it in the Device panel before installing or starting device tools. on three attempts, including after successful boot. the repository's test-t3-mobile skill explicitly requires stopping verification when device tools are unavailable. no alternative automation system was installed. stopped the emulator started for this attempt.

Not verified

ios cannot run on this linux vm. android app installation, pairing to a real dev server, real codex gpt-6.1-sol turns, PR monitor title/state/checks, external opening, neighboring rows, accessibility, and original-problem reproduction remain unverified. no before/after screenshots or interaction video were captured. contributor evidence was read but is not proof performed in this attempt. no source changes, checkout, installs, pushes, label changes, or other PR changes were made. device access must be enabled in this environment's Device panel to continue the required mobile workflow.

Verified on Android emulator (API 35) against a real dev server

verified head e3cc757341497ccf7825012b7b689b101bf27535 on AVD t3, Android API 35, with KVM. installed the matching native dev client from the shared cache and paired it to the isolated real server on port 13773, with Metro on 8081 and adb reverse for both. vp i passed. created a real project and thread through the server CLI; real Codex gpt-6.1-sol turns linked this PR and processed watch notifications. no mocks or demo data.

reproduced the old row using ThreadBackgroundWorkSheet.tsx from merge-base dd5b5401e1 against the same persisted thread/watch, then restored the exact head file and restarted Metro. this is a comparison of the old component and head component on the same native build, not a full checkout/run of current github/main. the old row showed "Watching pull request https://git.cafe/pingdotgg/t3code/pulls/21412" and "Monitor". the head row shows the real title, green https://git.cafe/pingdotgg/t3code/pulls/21412, and "Watching · Open". the GitHub watch additionally shows the green "checks passing" summary. both host links open the correct real PR in Chrome.

neighboring behavior: dismissed/reopened the sheet, returned from Chrome with the sheet preserved, and completed another real provider turn while keeping the existing watch. inspected the accessibility tree: the GitHub monitor label includes the number, full title, Open, and checks passing. the GitCafe summary does not supply checks state, so its row correctly omits the badge. captured both host links to this same PR to exercise that difference.

before, same real watch data:

after, exact PR head:

no source fixes, commits, or pushes were needed. the checkout is clean. cafe currently reports 27 successful checks, none failing or pending; those are separate from this runtime proof. no merge, close, rebase, force-push, or label changes.

Not verified

ios cannot run on this Linux VM. physical devices, dark theme, TalkBack hint announcement, snapshot-free fallback, failed external-opening alert, pending/failing checks, draft/merged/closed colors, and command/subagent rows were not exercised. no full current-main run was performed. no new automated checks were run because this pass changed no source.

@maria-rcks main's #26395 conflicted with this branch in orchestrationV2PendingBackgroundWork.ts. I merged main in acdc2edf95 (no rebase, no force-push). Main's new rule, that a merged PR's watch is not a monitor task, now lives in the shared isWatchedLink helper. pullRequestWatchTasks and findPullRequestForWatchTask therefore still agree. The native code paths you verified are unchanged.

Checks: the shared test file passes (21/21), lint on the file passes, and shared and mobile tsc --noEmit exit 0.